Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44392: Drop use of Reach UI #166

Merged
merged 13 commits into from
Jun 20, 2024
Merged

DM-44392: Drop use of Reach UI #166

merged 13 commits into from
Jun 20, 2024

Conversation

jonathansick
Copy link
Member

Reach UI is no longer maintained, unfortuantely, and it's blocking us from upgrading Node and Next. This PR removes usage of Reach components:

  • Alert for Times Square validation
  • Menu button, replaced with our custom GafaelfawrUserMenu based on Radix UI's react dropdown menu.

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 6ae78ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
squareone Minor
@lsst-sqre/squared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonathansick jonathansick changed the title DM-4432: Drop use of Reach UI DM-44392: Drop use of Reach UI May 16, 2024
This is no longer an accessible alert. We'd need to use
aria-invalid="true" on the input and then
aria-describedby on the input to connect to the id of the ErrorMessage
component.
We realized we probably want to re-engineer GafaelfawrUserMenu around
the Radix NavigationMenu. To make space for that new component, we'll
rename the DropdownMenu-based component. This will probably get deleted
later once the new user menu is commissioned.
This adds the component and a basic storybook based on the original
GafaelfawrUserMenuDropdown component. We'll add the Radix Navigation
Menu implementation next.
This is now semantically correct and accessible user menu. We still need
to tweak the presentation of the menu content so it pop down below
trigger.
This makes the menu functional... but we haven't yet replicated all the
fun animation functionality that's provided in the Radix example at
https://www.radix-ui.com/primitives/docs/components/navigation-menu
This new menu is in the @lsst-sqre/squared package.
- It seems that the a selector on the nav bar is overriding the
  specificity of the color rule on MenuLink, so I had to add important!
  there. This needs to be fixed.

  - Adjusted positioning of the drop down menu so it appears on the
    screen.
This makes it easier to develop the user menu...
This should ensure that squared and rubin-style-dictionary are always
rebuilt before running squareone in dev mode.
This was causing the menu bar to shift up after log in.
@jonathansick jonathansick marked this pull request as ready for review June 20, 2024 19:46
@jonathansick jonathansick merged commit 78a2306 into main Jun 20, 2024
12 checks passed
@jonathansick jonathansick deleted the tickets/DM-44392 branch June 20, 2024 19:48
@squareone-ci squareone-ci bot mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant